-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3006.x] Fix batch mode hang indefinitely in some scenarios #66758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test to follow |
dmurphy18
added
test:slow
Enable Slow Tests
test:full
Run the full test suite
test:pkg
Run the package tests
test:os:all
Run Tests Against ALL OS'es
labels
Jul 30, 2024
dmurphy18
changed the title
[WIP][3006.x] Fix batch mode hang indefinitely in some scenarios
[3006.x] Fix batch mode hang indefinitely in some scenarios
Aug 14, 2024
dwoz
approved these changes
Aug 14, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
test:full
Run the full test suite
test:os:all
Run Tests Against ALL OS'es
test:pkg
Run the package tests
test:slow
Enable Slow Tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix batch mode hang indefinitely in some scenarios
What issues does this PR fix or reference?
Fixes #66249
Previous Behavior
Batch mode occasionally hangs in some scenarios
New Behavior
No more hangs in batch mode
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices, including the
PR Guidelines.
See GitHub's page on GPG signing for more information about signing commits with GPG.